Fix embedding_in_qt4_wtoolbar.py on Python 3 #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. Tested it works with 2.6? |
|
Not tested with 2.6 and 2.7 yet. |
|
It "works" in 2.7, but I wonder if this example needs an overhaul. The toolbar is placed at the bottom, which doesn't seem to be the default location anymore for Qt4Agg. Also, the display of the cursor coordinates in the corner only works for a brief period before it only shows empty quotes. |
|
Is that a regression as a result of this PR? If not, I would suggest merging this and opening an issue (If @cgohlke is ready and willing to be an assignee, that would be even better :-) ) |
|
Looks like it is not a regression. The current version of the script also have the same problems. |
efiring
added a commit
that referenced
this pull request
Jul 22, 2012
Fix embedding_in_qt4_wtoolbar.py on Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.