Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'capthick' kwarg to errorbar() #1031

Merged
merged 4 commits into from Aug 17, 2012

Conversation

WeatherGod
Copy link
Member

Exactly what it says on the label. Probably should add some examples (or modify existing ones). Tests might be nice too...

@mdboom
Copy link
Member

mdboom commented Aug 3, 2012

Looks good. I would add or modify a regression test to use capthick so this doesn't get lost in the future. Aside from that, I think this is good to merge.

@WeatherGod
Copy link
Member Author

So, looking through the tests, there is only one place where we even bother testing errorbars, and that is in the svg backend tests. Methinks it is time to re-evaluate our coverage strategy...

@mdboom
Copy link
Member

mdboom commented Aug 14, 2012

You mean develop a coverage strategy... ;)

@mdboom
Copy link
Member

mdboom commented Aug 14, 2012

BTW - I was suggesting adding a new test for errorbars -- and something in particular that exercises the new capthick feature.

@WeatherGod
Copy link
Member Author

Almost ready with the first round of errorbar tests, slightly modified from the examples. Not exactly sure if my version of freetype (or the fonts installed) is yielding good quality baseline png images, though.

@WeatherGod
Copy link
Member Author

I think this PR of mine is ready for someone to give their stamp of approval and merge it in.

efiring added a commit that referenced this pull request Aug 17, 2012
Added 'capthick' kwarg to errorbar()
@efiring efiring merged commit d0c501b into matplotlib:master Aug 17, 2012
@WeatherGod WeatherGod deleted the errorbar_capthick branch July 23, 2014 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants