Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8-compliance on axes.py (patch 2 / 4) #1469

Merged
merged 1 commit into from Nov 19, 2012
Merged

PEP8-compliance on axes.py (patch 2 / 4) #1469

merged 1 commit into from Nov 19, 2012

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Nov 9, 2012

Here is the second patch for the pep8 compliance of axes.py

Thanks,
N

@@ -2659,7 +2663,10 @@ def yaxis_inverted(self):
return top < bottom

def get_ybound(self):
"Return y-axis numerical bounds in the form of lowerBound < upperBound"
"""
Return y-axis numerical bounds in the form of lowerBound <
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the equation should probably be on one line. Would you mind also wrapping it such that `... the form of ``lowerBound < upperBound``` so that it would get rendered as a code snippet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NelleV You need double back-ticks (as in @pelson's example) surrounding the inequality so sphinx will render it as a code snippet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry.. I didn't read properly the comment. It is fixed (properly this time).

@pelson
Copy link
Member

pelson commented Nov 9, 2012

👍 again. Thanks @NelleV !

@NelleV
Copy link
Member Author

NelleV commented Nov 19, 2012

I've rebased master on this PR, and travis indicates it is OK for merge :)

dmcdougall added a commit that referenced this pull request Nov 19, 2012
PEP8-compliance on axes.py (patch 2 / 4)
@dmcdougall dmcdougall merged commit f928a9d into matplotlib:master Nov 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants