Remove dead code in patches #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pad variable was never used in this function, so it is being removed. It also depended on a kwarg, which was also not used.
|
Agreed. I can't find anyplace where the leadingspaces kwarg was ever used. I will wait a little bit to see if anyone else can find anyplace where it was used. If so, we may have to do a deprecation process, but that might be overkill. |
|
@WeatherGod I think you're right; deprecation is overkill for this -- shall I go ahead and merge it? |
|
I think so. Better to do this now and let it bake for the entire dev |
dmcdougall
added a commit
that referenced
this pull request
Nov 15, 2012
Remove dead code in patches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pad variable was never used in this function, so it is being
removed. It also depended on a kwarg, which was also not used.