Workaround for QT cursor bug in dock areas #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cheers @ChrisBeaumont. I can confirm this fixes the issue. Merging. |
dmcdougall
added a commit
that referenced
this pull request
Dec 5, 2012
Workaround for QT cursor bug in dock areas
|
This is a pretty nice fix and it's a ridiculously tiny change. @mdboom Can I cherry-plonk this into v1.2.x? |
|
Yes: I think this makes sense to put on 1.2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone pointed out to me that the change in #1433 doesn't work when plots are embedded within QDockAreas (the cursor never changes). This is probably related to the Qt bug discussed here.
To reproduce the issue, under MPL 1.2.0: https://gist.github.com/4208745
This PR sets the cursor at a different level in the widget hierarchy, and seems to sidestep the problem.
Note that I haven't checked whether this change breaks the original problem addressed by #1404