Note minimum supported version for fontconfig. #15626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
force-pushed
the
fontconfig-minver
branch
2 times, most recently
from
1e31eb0
to
04219b1
Compare
dstansby
approved these changes
Nov 7, 2019
anntzer
force-pushed
the
fontconfig-minver
branch
from
04219b1
to
b489b96
Compare
dopplershift
reviewed
Nov 7, 2019
anntzer
force-pushed
the
fontconfig-minver
branch
from
b489b96
to
c93ab96
Compare
dopplershift
approved these changes
Nov 7, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 8, 2019
dstansby
added a commit
that referenced
this pull request
Nov 9, 2019
…626-on-v3.2.x Backport PR #15626 on branch v3.2.x (Note minimum supported version for fontconfig.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #15625.
See https://gitlab.freedesktop.org/fontconfig/fontconfig/blob/a919700f/README#L1399 for relevant fontconfig changelog entry.
The requirement for fc>=2.7 came in in #2433 (just 4y after the release of fc2.7) and #15625 (10y after the release of fc2.7) appears to be the first instance of someone running a too-old fontconfig, so I think we can reasonably choose to not support older versions.
PR Checklist