Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make font_manager ignore KeyErrors for bad fonts #1604

Merged
merged 1 commit into from Dec 17, 2012

Conversation

dmcdougall
Copy link
Member

Fixes #1601.

@dmcdougall
Copy link
Member Author

There are other try/except blocks in the file that do:

except:

and not even

except Exception:.

This should probably be updated. Perhaps in a different pull request.

@mdboom
Copy link
Member

mdboom commented Dec 17, 2012

I agree about the other empty try / except blocks -- but that can be a separate PR. This fixes a real issue (in #1601).

@dmcdougall
Copy link
Member Author

@mdboom That's what I thought. In that case this is ready to go. The Travis failure was a git clone timeout on Python 3.1, so nothing to worry about. The tests pass on Python versions 2.{6,7} and 3.2.

mdboom added a commit that referenced this pull request Dec 17, 2012
Make font_manager ignore KeyErrors for bad fonts
@mdboom mdboom merged commit 158cf33 into matplotlib:v1.2.x Dec 17, 2012
@dmcdougall
Copy link
Member Author

Cheers @mdboom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants