Legend: Also calc the bbox of the legend when the frame is not drawn. (1.2.x) #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This fixes gh1586
|
One could also add a test however this must be against master since the bbox_tight tests are only there. |
|
The Travis failure is not relevant. It fails to install nose on Python3.1 |
|
Why must the test only be added to the master branch? Worst case scenario is you add a test in v1.2.x and one of the developers merging v1.2.x into master sees a merge conflict. Am I missing something? |
|
I see. I'll merge this and then merge it to master, and fix any tests if necessary. |
mdboom
added a commit
that referenced
this pull request
Jan 16, 2013
Legend: Also calc the bbox of the legend when the frame is not drawn. (1.2.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1586