New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEP10: adding numpydoc and activating autosummary #1665
Conversation
Agreed - I don't think it should be in there personally - it is a reasonable dependency (and since it is a python package is easy enough to install). My only hesitation is in making sure that the error, when a developer doesn't have numpydoc, is a good and clear one. Nice change @NelleV |
Thanks for taking this on. This is really going to improve things. I'm of two minds about including |
Should we merge it as is, and see whether we want to keep numpydoc? Despite this PR being very preliminary work, I think it would already be a great addition to the docs. |
I feelings on this are to go the other way around. Lets depend on numpydoc rather than ship it and subsequently update docstrings sequentially and systematically in distinct pull requests. There is no compelling reason to ship numpydoc with mpl, and therefore adding the dependency as part of the codebase adds the possibility, in the future, of diverging versions (in precisely the same way that the plot directive did). |
I've deleted |
Excellent. @mdboom - please merge when your happy. 👍 |
Looks good. When #1454 is merged (there's still some puzzling issues with it on Travis), we can make the dependency on numpydoc explicit and pip should install it for us. Until then, I think it's fine to expect developers to have it installed already. Merging. Thanks for all this work. |
MEP10: adding numpydoc and activating autosummary
'matplotlib.sphinxext.plot_directive', 'sphinx.ext.inheritance_diagram', | ||
'gen_gallery', 'gen_rst', | ||
'matplotlib.sphinxext.ipython_console_highlighting', 'github'] | ||
'matplotlib.sphinxext.ipython_console_highlighting', 'github', | ||
'numpy_ext.numpydoc'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be numpydoc. I've submitted a PR to fix this.
@NelleV - I'm not getting the nice odd-even colour scheme with the method table - I the classes of my table rows are |
I'm also getting two method tables for Figure, but only one for AxesStack (in Any tips? |
@pelson I'm not sure.. What version of sphinx are you using? |
Sphinx 1.1.3. |
@pelson Same here. Have you made a "python make.py clean" before rebuilding the documentation ? |
Here is the first step in implementing MEP10 (point 1, and part of point 3)
Here is the screenshot of a page of the API
I chose to ship numpydoc with matplotlib, instead of asking developpers to install it. That point is debatable.
Also, because of numpydoc, the documentation will not build for sphinx below 1.0.