Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt closeevent fixes for v1.2.x #1705

Merged
merged 10 commits into from Jan 28, 2013
Merged

Commits on Jan 26, 2013

  1. Merge pull request matplotlib#1678 from tacaswell/qt4_closeevent

    added QtGui.QMainWindow.closeEvent() to make sure the close event
    dmcdougall authored and tacaswell committed Jan 26, 2013
    Copy the full SHA
    726e67e View commit details
    Browse the repository at this point in the history
  2. Re-wired signal/slot connections so that the figure in removed from

    Gcf when it is closed.
    
    In PR matplotlib#1498 the attribute WA_DeleteOnClose was no longer set on the
    QtMainWindow object in QtFigureManager.  The signal connection that
    was being used to remove the figure from Gcf when the window was closed
    was tied to the `destroyed()` signal of QtMainWindow, which is no
    longer being destroyed.  Thus, gca and gcf would return references
    to no-longer visible figures/axes.  _widgetclosed is now called when
    MainWindow emits 'closing()'.
    Thomas A Caswell authored and tacaswell committed Jan 26, 2013
    Copy the full SHA
    45f8701 View commit details
    Browse the repository at this point in the history
  3. PEP8: whitespaces

    Thomas A Caswell authored and tacaswell committed Jan 26, 2013
    Copy the full SHA
    35204ed View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    c3cb882 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    3d3f8c3 View commit details
    Browse the repository at this point in the history
  6. test for issue matplotlib#1683

    tacaswell committed Jan 26, 2013
    Copy the full SHA
    75a92df View commit details
    Browse the repository at this point in the history
  7. fixed link rot

    tacaswell committed Jan 26, 2013
    Copy the full SHA
    2457745 View commit details
    Browse the repository at this point in the history
  8. removed unused import

    tacaswell committed Jan 26, 2013
    Copy the full SHA
    4ed4695 View commit details
    Browse the repository at this point in the history
  9. added knownfailureif to test based on if qt4_compat could be imported,

    as this should hit either PySide or PyQt4, depending on which is
    installed.  (I have faith that the setup code that will make sure that
    if only one of them is installed, it defaults to using that one)
    tacaswell committed Jan 26, 2013
    Copy the full SHA
    7362cdc View commit details
    Browse the repository at this point in the history
  10. added test_backend_qt4 to test list

    Thomas A Caswell authored and tacaswell committed Jan 26, 2013
    Copy the full SHA
    671e0ec View commit details
    Browse the repository at this point in the history