Fix bugs in stacked histograms #1706
Conversation
| p.set_snap(False) | ||
| patch.update(kwargs) | ||
| if lbl is not None: | ||
| patch.set_label(lbl) |
There was a problem hiding this comment.
Since the switch to fill_between, we're dealing with a PolyCollection rather than a list of patches. Thus, some changes here. I also put the patches from the bar histtype into a PatchCollection, so they can be treated using the same interface.
|
This currently targets master. Should it instead target v1.2.x if its intent is to fix a bug? |
|
I suppose you're correct. Let's get it working first, then I'll switch it over. |
|
If this changes the output type of the call to PolyCollection from a list |
|
I think we can keep the API the same by just returning |
Actually, not only the type of the returned value needs to be the same, but the order in which they appear in the returned iterable needs to be unchanged as well. |
|
Let's cross that bridge when we come to it. Right now, this isn't even working properly. |
| patches.append(self.fill(x, y, | ||
| closed=False, facecolor=c)) | ||
| patches.append(self.fill_between(x, y, y_bottom, | ||
| closed=False, facecolors=c)) |
There was a problem hiding this comment.
PEP8 nitpick: this line is under-indented: it should be align with the opening ( of the previous line
|
Closed in favor of #1723. |
Hi,
This is an attempt to fix both #1679 and #1631, which both came about because of the way that stacked histograms are handled, introduced in #847.
This isn't ready to go in yet, but I'm running into some problems getting it to work correctly, so I thought I'd try to get some more eyes on it.
There are two problems I'm running into:
fill_betweenisn't actually fillingfill_betweenseems to be screwing up autosetting the y axis limits.Here is the image I get when I run
test_hist_stacked. The two histograms are now in the proper order, fixing #1679, you can see the two problems I mentioned. The histograms should be filled and the minimum of the y-axis should be 0.Could someone a little more familiar with
fill_betweentake a look at this?