Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC improves documentation on the pyplot module and the bar method #1757

Merged
merged 1 commit into from Apr 18, 2013
Merged

Conversation

NelleV
Copy link
Member

@NelleV NelleV commented Feb 18, 2013

This patch contains some MEP10 documentation improvements on the bar's method, and some small PEP8 fixes on the pyplot module.

Thanks,
N

@pelson
Copy link
Member

pelson commented Feb 18, 2013

some small PEP8 fixes on the pyplot module

FWIW #1760 fixes some of the whitespace issues not addressed in this PR (so no conflicts 😄 )

or sequences
Parameters
----------
left : sequence of scalars
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sequence or scalars? Or was that intentional? It's no longer clear that scalars may be given.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was intentional, but that because I forgot the case of the horizontal bar plot, where one may want to pass a scalar here.

@mdboom
Copy link
Member

mdboom commented Feb 25, 2013

Looks good to me. Glad to have MEP10 rolling in.

horizontal bars, *align* = 'edge' aligns bars by their bottom
edges in bottom, while *align* = 'center' interprets these
values as the *y* coordinates of the bar centers.
linewidth : scalar or sequence of scalar, optional, default: None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an 's': scalar or sequence of scalars

@dmcdougall
Copy link
Member

Is it possible to restart this Travis job? The option is greyed out for me.

@NelleV
Copy link
Member Author

NelleV commented Mar 23, 2013

@dmcdougall I've rebased. This should restart travis.

pelson added a commit that referenced this pull request Apr 18, 2013
DOC improves documentation on the pyplot module and the bar method
@pelson pelson merged commit eb59a06 into matplotlib:master Apr 18, 2013
@pelson
Copy link
Member

pelson commented Apr 18, 2013

Good work @NelleV (again)!

@NelleV NelleV deleted the MEP10 branch September 6, 2016 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants