New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webagg changes #1878
Webagg changes #1878
Conversation
Note: one of the changes I was referring to was to JSLint the javascript - I'd be happy to do that here before anybody sets their eyes on my (probably poor) javascript. Shout if you'd like that to happen now, otherwise, I'll probably defer the linting to my next PR ;-) |
def __init__(self, url_prefix=''): | ||
if url_prefix: | ||
assert url_prefix[0] == '/' and url_prefix[-1] != '/', \ | ||
'url_prefix must start with a "/" and not end with one.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we instead just add the prefix /
if it's not there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are fine, it's something most people will never use (I don't propose making in an RcParam) - its for follow on applications (which I plan to look at in the next couple of weeks) for which I will want to implement a namespace. The one thing in favour of this approach is that there is no ambiguity - if you get it wrong then you will get a decent message about it, but I can also see the other side of the argument too (if you can check that something is wrong, you can fix it programatically for the user...)
This is great. I think the objectification work you've done to allow multiple figures on the same page will come in very handy when this gets integrated with IPython notebook. (I hope to hash out a plan for that at Scipy if I can get all the experts in the room together...) I am getting this message when I run this (haven't really looked into why):
|
Fixed the favicon directory problem in 786a6b4. |
@mdboom - any actions on this? I'm keen to reduce my number of PRs 😄 |
Now that the favicon thing is fixed, I think this is good to go. |
Cool. Thanks @mdboom. I'm going to start up a conversation on the ipython-dev mailing list in the next week or so to start thinking about notebook magic. I'd like to be able to use it in a talk at SciPy 😉 |
Some refactoring work on the WebAgg backend.
Key features:
127.0.0.1/mpl/*
, if you so desired)mpl_interface.js
factory functionsI've been testing this out with the following code:
I still have some other changes I'd like to make to the WebAgg architecture, but I think this is a reasonable first step which adds some nice, self contained, functionality.