Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default quit keymap - support for cmd+w on OSX #1902

Merged
merged 1 commit into from May 11, 2013

Conversation

cimarronm
Copy link
Contributor

Updated default quit keymap to include cmd+w so people running on OS X would have a native cmd+w to close the window.

@pelson
Copy link
Member

pelson commented Apr 12, 2013

Thanks @cimarronm - I agree that any user on OSX should expect cmd+w to quit the plot window.

Is this on the macosx backend? For me, (tkagg on mountain lion) cmd+w quits anyway, I'd be interested to know how many of the other backends are the same. Maybe we should have a specific (non-configurable) keymapping in the macosx backend which adds this directly.

@cimarronm
Copy link
Contributor Author

Yeah, this is on the macosx backend. It is the only one which generates a cmd modifier so I think the default keymap modification from ctrl+w to ctrl+w, cmd+w should be safe.

…X would have a native cmd+w to close the window.
efiring added a commit that referenced this pull request May 11, 2013
Default quit keymap - support for cmd+w on OSX
@efiring efiring merged commit 9e734b6 into matplotlib:master May 11, 2013
@efiring
Copy link
Member

efiring commented May 11, 2013

This works on the macosx backend, and does not change the others. tkagg apparently internally translates Ctrl-W into Cmd-W. Wx does the same, based on my version 2.9, for which mpl is mostly broken. qt4agg backend did nothing with Cmd-W before, and still does nothing. That's because it is calling the command prefix "super" instead of "cmd", after having un-done the swap that qt does: http://qt-project.org/doc/qt-4.8/qkeysequence.html.

@dmcdougall
Copy link
Member

That's because it is calling the command prefix "super" instead of "cmd", after having un-done the swap that qt does: http://qt-project.org/doc/qt-4.8/qkeysequence.html.

I'd be amenable to opening an issue for that. Any objections?

@efiring
Copy link
Member

efiring commented Jun 19, 2013

No objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants