Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-arrange mplDeprecation imports #1946

Merged
merged 2 commits into from Apr 29, 2013

Conversation

tacaswell
Copy link
Member

in #1917 @NelleV requested I import mplDeprecation directly from cbook. On further investigation I found that none of the current code did that.

This PR changes the import scheme to import directly from cbook everywhere.

and changed all cases of

from matplotlib import MatplotlibDeprecationWarning as mplDeprecation

to

from cbook import mplDeprecation
@NelleV
Copy link
Member

NelleV commented Apr 25, 2013

Thanks for doing this work.

You should explicitely import cbook: either use from .cbook import blah or from matplotlib.cbook import blah.
I personnally prefer the first version, but matplotlib's codebase uses the latter (and it is the recommanded way of importing a intra package module).

@tacaswell
Copy link
Member Author

Should lines like

iterable = cbook.iterable
is_string_like = cbook.is_string_like
is_sequence_of_strings = cbook.is_sequence_of_strings

(from axes.py) be changed to from matplotlib.cbook import blah ?

@NelleV
Copy link
Member

NelleV commented Apr 25, 2013

I think it would be cleaner, but I think this is a question of personal taste so I'll leave it up to you.

@tacaswell
Copy link
Member Author

My inclination is to not change code that works, so I will leave it ;)

efiring added a commit that referenced this pull request Apr 29, 2013
re-arrange mplDeprecation imports
@efiring efiring merged commit 3b972d6 into matplotlib:master Apr 29, 2013
@tacaswell tacaswell deleted the mpldeprec_imports branch April 29, 2013 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants