Better axis limits when using shared axes and empty subplots #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1895,6 +1895,10 @@ def autoscale_view(self, tight=None, scalex=True, scaley=True): | |||
| if scalex and self._autoscaleXon: | |||
| xshared = self._shared_x_axes.get_siblings(self) | |||
| dl = [ax.dataLim for ax in xshared] | |||
| #ignore non-finite data limits if good limits exist | |||
| if any(np.isfinite(d).all() for d in dl): | |||
| dl = [d for d in dl if np.isfinite(d).all()] | |||
There was a problem hiding this comment.
I wonder if there's a way to do this without calculating np.isfinite(d).all() twice for each element. Maybe something like:
finite_dl = [d for d in dl if np.isfinite(d).all()]
if len(finite_dl):
dl = finite_dl
|
Looks good. Needs a test -- I don't think it will need to be an image comparison test. |
|
Added a test |
|
Ok. 👍 from me, then. Might let this sit for a few days to get other feedback, but this makes sense to me. |
dmcdougall
added a commit
that referenced
this pull request
Aug 31, 2013
Better axis limits when using shared axes and empty subplots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one possible solution to #2356