Tst/restore old tests #26131
Merged
Tst/restore old tests #26131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
force-pushed
the
tst/restore_old_tests
branch
from
66ec46f
to
b37850f
Compare
Adding |
tacaswell
force-pushed
the
tst/restore_old_tests
branch
from
b37850f
to
d42b548
Compare
QuLogic
approved these changes
Mar 6, 2024
|
It looks like |
tacaswell
force-pushed
the
tst/restore_old_tests
branch
from
d42b548
to
b85c527
Compare
…_neg_coords"" This partially reverts commit 7b71257. Too many tests were removed, restore the extra tests.
Remove the light font because we don't have a good one on mac on CI
tacaswell
force-pushed
the
tst/restore_old_tests
branch
from
b85c527
to
d96d68c
Compare
ksunden
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
In 7b71257 via #4843 I intended to revert the changes from #4019 however, I incorrectly resolved the merge conflicts and also removed the tests added in #4023 and #4342.
This is attempting to put them back. There are two complications:
Annotationdefaulting to data coordinates when added directly to aFigurethat does not have an Axes. I'm not clear why this ever worked (we must have had more complicated default coordinate behavior?!).I found this issue while looking at what images were in our repo that were not generated by running the test suite.