Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in color mapping documentation in quick_start.py #28102

Merged
merged 1 commit into from Apr 19, 2024

Conversation

lubianat
Copy link
Contributor

PR summary

I found this typo while browsing the "Quick start guide." Instead of "a colors," it should read "colors," as far as I can tell.

PR checklist

@github-actions github-actions bot added the Documentation: user guide files in galleries/users_explain or doc/users label Apr 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@tacaswell tacaswell merged commit 791bfe0 into matplotlib:main Apr 19, 2024
21 checks passed
@tacaswell tacaswell added this to the v3.9.0 milestone Apr 19, 2024
@tacaswell
Copy link
Member

Thanks! I'm 75/25 in favor of this resolution rather than "by a color in colormap", either would probably be OK, but I also like the version in this PR better.

Thank you for you work on this @lubianat and congratulations on your first merged Matplotib PR 🎉

I hope we hear from you again!

@tacaswell
Copy link
Member

@meeseeksmachine please backport to 3.9.x

@lubianat
Copy link
Contributor Author

@tacaswell thanks! Yep, I had the same question myself. I hope I can contribute more in the future, though I am not a super dev like you all :)

@tacaswell
Copy link
Member

My first PR was to change a 4 to a 7 #1062

@QuLogic
Copy link
Member

QuLogic commented Apr 22, 2024

@meeseeksdev backport to v3.9.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 22, 2024
QuLogic added a commit that referenced this pull request Apr 23, 2024
…102-on-v3.9.x

Backport PR #28102 on branch v3.9.x (Fix typo in color mapping documentation in quick_start.py)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation: user guide files in galleries/users_explain or doc/users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants