Fix for issue #2541 (revised) #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -151,6 +151,7 @@ def transform_non_affine(self, xy): | |||
|
|
|||
| theta -= theta_offset | |||
| theta *= theta_direction | |||
| theta = theta % (2 * np.pi) | |||
There was a problem hiding this comment.
Keeps theta between 0 and 2pi
There was a problem hiding this comment.
Minor style: you might as well follow the lead of the two lines above, and use theta %= (2 * np.pi).
|
@Rickkwa Can you also add an entry in CHANGELOG and whats_new.rst? |
|
@tacaswell What date should I use for the CHANGELOG (date of commit? Today's date?). Also, does a small bug fix like this warrant an entry in the whats_new.rst? It doesn't seem like there is a suitable section. |
|
I tend to do date of commit (and putting it a bit down well protect you from nasty rebase issues). I think you could put a sentence in the plotting improvements section. |
|
@Rickkwa This needs to be re-based. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for issue #2541
Explanation:
Say the plot has the 0 facing North and it goes counter clockwise. The offset is 0.5_pi (as set in the set_theta_zero_location() function).
Then if the mouse is in the first quadrant, the theta variable is in the range of [0, 0.5_pi] (before applying offset and direction). In line 152, we account for the offset by subtracting the offset amount.
This gives us a negative number, which is the problem.