Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clip_on documentation note/warning #2929

Merged
merged 2 commits into from May 29, 2014

Conversation

fariza
Copy link
Member

@fariza fariza commented Mar 26, 2014

This try to fix the comment on PR #2837

Warning:
I didn't even knew the clip_on existence and I'm not sure I am describing the results correctly.
I am just paraphrasing @tacaswell from https://stackoverflow.com/questions/21615285/how-to-not-cut-flatten-lines-when-moving-the-spines-in-matplotlib/21617349#21617349

@fariza
Copy link
Member Author

fariza commented Apr 17, 2014

@tacaswell Is something more needed?

@@ -644,6 +644,9 @@ def set_clip_on(self, b):
"""
Set whether artist uses clipping.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change this to 'Set whether the artist is clipped to the axes.'

@tacaswell
Copy link
Member

I need to be more careful about what I write on SO....

@tacaswell tacaswell added this to the v1.4.0 milestone Apr 20, 2014
tacaswell added a commit that referenced this pull request May 29, 2014
clip_on documentation note/warning
@tacaswell tacaswell merged commit e2c5918 into matplotlib:master May 29, 2014
@tacaswell
Copy link
Member

Spells out what clipping is rather than using the 'clip to' language, but if 'clip to' makes sense to the user they probably guessed what this does anyway.

@fariza fariza deleted the clip-on-doc-warning branch February 11, 2015 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants