Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid np.nan values in colors array returned by axes3d._shade_colors #3031

Merged
merged 2 commits into from May 13, 2014
Merged

avoid np.nan values in colors array returned by axes3d._shade_colors #3031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81b5241
avoid np.nan values in colors array returned by axes3d._shade_colors
jrjohansson May 2, 2014
1d8c18b
make sure fill values for shade array are within the correct range
jrjohansson May 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/mpl_toolkits/mplot3d/axes3d.py
View file
Open in desktop
Expand Up @@ -1675,11 +1675,13 @@ def _shade_colors(self, color, normals):
'''

shade = np.array([np.dot(n / proj3d.mod(n), [-1, -1, 0.5])
if proj3d.mod(n) else np.nan
for n in normals])
mask = ~np.isnan(shade)

if len(shade[mask]) > 0:
norm = Normalize(min(shade[mask]), max(shade[mask]))
shade[~mask] = min(shade[mask])
color = colorConverter.to_rgba_array(color)
# shape of color should be (M, 4) (where M is number of faces)
# shape of shade should be (M,)
Expand Down