Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG : fix for text path rendering issues #3054

Closed
wants to merge 1 commit into from

Conversation

tacaswell
Copy link
Member

Suggested by @leejjoon.

Fixes #2889

@tacaswell tacaswell added this to the v1.4.0 milestone May 9, 2014
@tacaswell
Copy link
Member Author

This still needs a test + docs.

@pelson
Copy link
Member

pelson commented May 14, 2014

This still needs a test + docs.

I'm not sure about the docs, but the test should be relatively straight forward. It also appears to be impacting other test results, suggesting that this functionality is fixing already tested behaviour.

I'm 👍 on merging the method once the (potentially simple, picture-less) test exists.

@tacaswell
Copy link
Member Author

It looks like it is breaking existing behavior....

I don't really understand what is going on here well enough to write tests.

@pelson
Copy link
Member

pelson commented May 21, 2014

`FAIL: matplotlib.tests.test_patheffects.test_patheffect3``

This is good. It fixes an image which I added a few months ago (in which I struggled to get the font to be the expected size!!!).

FAIL: matplotlib.tests.test_patheffects.test_collection

This is good too - it fills the space in the boxes that I (again) struggled to understand why it didn't in the first place (test also added by me a few months ago).

So all in all - this is doing the right thing 😄

@pelson pelson mentioned this pull request May 21, 2014
@pelson
Copy link
Member

pelson commented May 21, 2014

Closed in favour of #3081.

@pelson pelson closed this May 21, 2014
@tacaswell tacaswell deleted the text_path_fix branch May 21, 2014 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: path effects in text() change text properties
2 participants