Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorbar: fmt kwarg defaults to None; use 'none' to suppress plot call #3103

Merged
merged 1 commit into from Jun 8, 2014

Conversation

efiring
Copy link
Member

@efiring efiring commented Jun 1, 2014

Closes #2366, as an alternative to #2738.

@@ -52,7 +52,12 @@ original location:

* The :func:`~matplotlib.pyplot.errorbar` method has been changed such that
the upper and lower limits (*lolims*, *uplims*, *xlolims*, *xuplims*) now
point in the correct direction.
point in the correct direction. The *fmt* kwarg is now handled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves it's own bullet.

@tacaswell
Copy link
Member

This seems like a big API break to me which is why I had addressed by just changing the default to ''. Anyone who is intentionally suppressing plotting the line now using None is going to have this break their code.

@efiring
Copy link
Member Author

efiring commented Jun 2, 2014

How about a compromise to provide a smoother change: default value of the fmt kwarg could be '' as in your PR, 'none' could be the documented way of plotting nothing, and None could be a deprecated equivalent, complete with warning. Changing it from a deprecated equivalent to having its normal meaning could be done with mpl 2.0, whenever we have accumulated enough such API changes. I think it is important to support the 'none' kwarg value now; changing to the usual usage of None is less urgent.
@WeatherGod, @pelson: thoughts?

@WeatherGod
Copy link
Member

That could work. Make sure we make a task to make the final transition in
the future.

On Mon, Jun 2, 2014 at 2:10 PM, Eric Firing notifications@github.com
wrote:

How about a compromise to provide a smoother change: default value of the
fmt kwarg could be '' as in your PR, 'none' could be the documented way
of plotting nothing, and None could be a deprecated equivalent, complete
with warning. Changing it from a deprecated equivalent to having its normal
meaning could be done with mpl 2.0, whenever we have accumulated enough
such API changes. I think it is important to support the 'none' kwarg
value now; changing to the usual usage of None is less urgent.
@WeatherGod https://github.com/weathergod, @pelson
https://github.com/pelson: thoughts?


Reply to this email directly or view it on GitHub
#3103 (comment)
.

@efiring
Copy link
Member Author

efiring commented Jun 2, 2014

If there is agreement that this is the right approach, I will squash it down to a single commit.

@tacaswell
Copy link
Member

This looks good to me.

tacaswell added a commit that referenced this pull request Jun 8, 2014
errorbar: fmt kwarg defaults to None; use 'none' to suppress plot call
@tacaswell tacaswell merged commit 9c99f28 into matplotlib:master Jun 8, 2014
@efiring efiring deleted the errorbar_defaults branch June 8, 2014 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errorbar plot ignores linestyle rcParam
3 participants