-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend marker label placement #3499
Legend marker label placement #3499
Conversation
Cool! I wonder if it would make more sense to right align everything -- this is just an aesthetic issue, so take it with a grain of salt. Instead of (where xxx is text and XXX is markers):
do:
Then the markers are more pleasantly aligned. |
cf743a4
to
a612d84
Compare
@mdboom, that definitely makes sense. I'll look into modifying to right align it when markers are on the right |
align="baseline", | ||
children=itemBoxes)) | ||
sep=self.labelspacing * fontsize, | ||
align="baseline" if markerfirst else "right", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan of the in-line logic, but not enough to make more fuss than leaving a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'm not either but was being lazy. I'll rework it to remove it ternary if
Can you re-base this to erase the old test images from history? |
Yeah, I'll remove the old image |
11f85b6
to
5812b57
Compare
@cimarronm Could you re-run boilerplate.py to update pyplot with the new kwargs? |
This should also get a |
|
It may be the case that boilerplate has not been run in a while... |
Also remember that boilerplate.py runs off of the installed version of Ben Root On Sat, Oct 18, 2014 at 1:44 PM, Thomas A Caswell notifications@github.com
|
…kers and labels. One now has the ability to place the marker to the right of the label.
@tacaswell Rebased on top of latest master and ran def legend(*args, **kwargs):
ret = gca().legend(*args, **kwargs)
draw_if_interactive()
return ret |
66850c6
to
d7210ff
Compare
ENH : Legend marker label placement control
Controls horizontal marker placement so that one specify either maker first or label first in the legend. This incorporates the feature request in issue #3285.