Minor tick fix [backport to 1.4.x] #3612
Conversation
|
Do the tests pass locally for you? |
|
They do pass locally for me, although I might not be running them correctly. I've fixed the pep8 errors (I hope). The other errors are with the |
|
@nhmc How are you running the tests? The tests run from the installed version of mpl, not the source version. |
| @@ -36,6 +36,18 @@ def test_MultipleLocator(): | |||
| assert_almost_equal(loc.tick_values(-7, 10), test_value) | |||
|
|
|||
|
|
|||
| def test_AutoMinorLocator(): | |||
There was a problem hiding this comment.
The problem is that this test is creating a figure which is leaking out and getting re-used in the next test (global state strikes again!).
This test either needs an @cleanup decorator or to be re-written to test the locator without creating a figure/axes. I strongly prefer the second.
|
expected:
Result:
Note the limits match the new test. |
|
Thanks for looking at this. I'll check in a fix soon. On 14 November 2014 01:27, Thomas A Caswell notifications@github.com
|
BUG : fix minor tick placement Merging by hand as I added a testing clean up commit on top of the original branch.
BUG : fix minor tick placement Merging by hand as I added a testing clean up commit on top of the original branch.
|
cherry-picked as 50625de |
This pull request ensures minor ticks are positioned correctly with
AutoMinorLocator, fixing the bug described in issue #3557.