Bug fix for plotting minor ticks

[nhmc]

When using AutoMinorlocator the rightmost minor tick isn't drawn sometimes (in Matplotlib 1.4). Changing this line in class AutoMinorLocator(Locator) (in ticker.py) from:

tmax = np.floor((vmax - t0) / minorstep) * minorstep

to

 tmax = np.ceil((vmax - t0) / minorstep) * minorstep

fixes this. I don't completely understand the code though, so this may not be the best fix.

[efiring]

Would you provide a minimal script that illustrates the bug, please?

[nhmc]

import matplotlib.pyplot as plt
plt.plot([1,2,3])
plt.minorticks_on()
plt.xlim(0, 1.39)
plt.show()

In this case the highest minor tick on the x axis is missing.

[nhmc]

I'm happy to open a PR adding the fix in the original post - let me know if I should do that.

[tacaswell]

Please do so, but I would re-write it as

tmax = ((vmax - t0) // minorstep) + 1) * minorstep

Please branch of off the 1.4.x and make the PR against the same (as this is a bug-fix not a new feature).

[WeatherGod]

Should also add a test, and make sure the same problem doesn't happen on
the other side of the axis.

On Wed, Sep 24, 2014 at 8:48 AM, Thomas A Caswell notifications@github.com
wrote:

Please do so, but I would re-write it as

tmax = ((vmax - t0) // minorstep) + 1) * minorstep

Please branch of off the 1.4.x and make the PR against the same (as this
is a bug-fix not a new feature).

—
Reply to this email directly or view it on GitHub
#3557 (comment)
.

[tacaswell]

closed by #3612