fix for #3669 Font issue without PyCXX #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like CharacterComplement doesn't return a unicode string so make it a bytestring in python3
|
Looks good. Thanks! |
mdboom
added a commit
that referenced
this pull request
Oct 20, 2014
fix for #3669 Font issue without PyCXX
|
characterComplement is essentially a bitfield. See here: http://www.microsoft.com/typography/otspec/pclt.htm If we wanted to provide a really Pythonic API to it, it would probably be a list of bools or something. But matplotlib itself doesn't even use this, and it's part of matplotlib's public API so I didn't want to change it (well, not intentionally). |
|
Thanks for the explanation. I didn't manage to google a good explanation of CharacterComplement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3669 for me. It looks like CharacterComplement doesn't return a valid unicode string so make it a bytestring in python3
This happens to me for the standard matplotlib font matplotlib/mpl-data/fonts/ttf/Vera.ttf
not sure why it doesn't happen on travis.
In any case 'characterComplement' is '\xff\xff\xff\xff6\xff\xff\xfe628R00' for this font on both python2 and python3 which looks rather strange to me. I expected this to be a string of all chars that this font contains so perhaps there is a deeper issue?