Use is to compare with None in backend_pdf #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jenshnielsen: I am working on removing PyCXX from _tri and will hopefully issue a PR tomorrow. |
|
@ianthomas23 Great stuff. This was not to put any pressure on you. Just to say that it was a waste of time to investigate the warnings in the present code. |
tacaswell
added a commit
that referenced
this pull request
Oct 26, 2014
ENH : Use is to compare with None in backend_pdf
tacaswell
added a commit
that referenced
this pull request
Dec 12, 2014
ENH : Use is to compare with None in backend_pdf
|
backported as 431edb7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the Numpy future warnings raised with numpy 1.9
The remaining ones are thrown from the Capi inside _tri.cpp and are likely related to the use of PyCXX. I don't think that there is much point in fixing them if the plan is to replace the use of PyCXX with the pure Python Capi