Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a local copy of Rgb2lab to plot colormap guide [backport to 1.4.x] #3726

Closed
wants to merge 4 commits into from

Conversation

jenshnielsen
Copy link
Member

Closes #3442 and #3685

This uses a local rgb2lab converted to avoid depending on scikit image when building the docs as suggested by @mdboom . Rather than implementing our own I have copied the one from scikit-image with a few modifications.

@tacaswell tacaswell added this to the v1.4.3 milestone Oct 27, 2014
@tacaswell tacaswell changed the title Use a local copy of Rgb2lab to plot colormap guide Use a local copy of Rgb2lab to plot colormap guide [backport to 1.4.x] Oct 27, 2014
@tacaswell
Copy link
Member

Is all of that code strictly needed? It looks like we really only need rgb2lab and I would lean towards pulling the minimal amount of code needed to make this work.

@jenshnielsen
Copy link
Member Author

I guess that there are two different options. Pull the minimal amount of code or pull the code with the minimal number of changes. I went for the later solution to make resynchronisation with the original as easy as possible, but I am happy to strip out the sections that we don't need if you think that is better.

@tacaswell
Copy link
Member

That is a very good point that I had not considered.

I don't have a good sense the long-term maintenance burden trade off here.

@jenshnielsen
Copy link
Member Author

I will write up another PR with the minimum and then we can see how that looks

@jenshnielsen jenshnielsen mentioned this pull request Oct 28, 2014
@jenshnielsen
Copy link
Member Author

@tacaswell @mdboom any thoughts on which of this and #3737 is the most clean approach. I would like to get rid of this misplaced branch

@jenshnielsen
Copy link
Member Author

Closing replaced by #3737

@jenshnielsen jenshnielsen deleted the rgb2lab_local branch November 5, 2014 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figures in http://matplotlib.org/users/colormaps.html require scikit-image to build
3 participants