Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert deprecation warning for set_graylevel #3812

Merged
merged 2 commits into from Nov 21, 2014

Conversation

jbmohler
Copy link
Contributor

Pursuant to comments in #3683 , this is a deprecation warning for set_graylevel in the backends.

  • it is not used (aside from the inheritance chain calls)
  • it has never been used according to git history
  • it delivers functionality which is trivial to attain other ways

@tacaswell
Copy link
Member

@mdboom Do we add an entry to api_changes when we slate stuff for removal? If not, we probably should.

@tacaswell
Copy link
Member

👍 On this modulo documentation from me

@mdboom
Copy link
Member

mdboom commented Nov 18, 2014

Yes -- I think we should an entry into api_changes.rst for this, under a new heading "Changes in 1.5.x". Thanks for doing this, @jbmohler. Removing unused code is always a good thing.

@jbmohler
Copy link
Contributor Author

yep, the programming days I'm happiest is when my net lines of code is negative!

@tacaswell
Copy link
Member

Can you put it in it's own file in the api_changes folder? This is a scheme to reduce doc-conflict caused rebases.

@jbmohler
Copy link
Contributor Author

@tacaswell that's a good idea. I took the opportunity to clarify my grammar as well.

tacaswell added a commit that referenced this pull request Nov 21, 2014
API : insert deprecation warning for set_graylevel
@tacaswell tacaswell merged commit 0656436 into matplotlib:master Nov 21, 2014
@jbmohler jbmohler deleted the deprecate_graylevel branch November 22, 2014 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants