Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbook.is_sequence_of_strings knows string objects #4358

Merged
merged 1 commit into from Apr 30, 2015

Commits on Apr 27, 2015

  1. cbook.is_sequence_of_strings knows string objects

    **Issue**
    `cbook.is_sequence_of_strings` cannot tell of a pandas series
    is contains strings. Pandas series are numpy arrays of type
    `object`.
    
    **Problem**
    `cbook.is_sequence_of_strings` uses `cbook.is_string_like` to dismiss
    strings as not sequences of strings. However, numpy string arrays
    of `dtype=object` are string-like since they support string
    concatenation.
    
    **Solution**
    Do not dismiss an `ndarray` if it appears string-like, go ahead and
    peak inside.
    has2k1 committed Apr 27, 2015
    Copy the full SHA
    ffbfdb7 View commit details
    Browse the repository at this point in the history