ENH: property if DrawingArea clips children #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cf #4466 |
Add proprety `clip_children` to provide user interface if DrawingArea tries to clip it's children.
tacaswell
force-pushed
the
enh_offsetbox_clip_children
branch
from
fd8a41b
to
7c3c98b
Compare
|
👍 Seems sensible to me. However, I would prefer if the |
|
I don't feel strongly about this so it up to you |
| @clip_children.setter | ||
| def clip_children(self, val): | ||
| self._clip_children = bool(val) | ||
| self.stale = True |
There was a problem hiding this comment.
it is only stale if the state changes, right?
There was a problem hiding this comment.
Yes, but there are only a few checks anywhere else. This problem will either be solved if we go with a managed attributes meta-class (i.e. traitlets) or slowly as it annoys people.
|
ping @WeatherGod |
|
Looks good to me now |
WeatherGod
added a commit
that referenced
this pull request
Jul 16, 2015
ENH: property if DrawingArea clips children
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proprety
clip_childrento provide user interface if DrawingArea tries to clip it's children.Did not include get/set methods and used property instead. I hope going forward we will drop the
set/get_*methods in favor of some sort of descriptor based solution.getp/setpshould probably be updated to look for properties first and then for getter/setter methods. That can be added to this PR or can be put off until after we sort out if we are going to use traitlets.Builds on work of @has2k1