Fix alpha channels in PDF images #4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was conflating the presence of an alpha channel with whether the image is grayscale or RGB. Fixes matplotlib#4331
|
Looks reasonable to me. Can you add a test for this as well? |
|
The Travis build seemed to fail with "gdb: command not found" so I just restarted it on the hypothesis that it was a spurious error with the builder. |
jenshnielsen
added a commit
that referenced
this pull request
Jul 7, 2015
Fix alpha channels in PDF images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was conflating the presence of an alpha channel with whether the image is grayscale or RGB.
Fixes #4331