Skip to content

Conversation

ericmjl
Copy link
Contributor

@ericmjl ericmjl commented Jul 11, 2015

No description provided.

@jenshnielsen
Copy link
Member

PEP8 too

/home/travis/build/matplotlib/matplotlib/examples/pylab_examples/text_handles.py:11:1: E302 expected 2 blank lines, found 1
/home/travis/build/matplotlib/matplotlib/examples/pylab_examples/text_handles.py:33:1: W391 blank line at end of file

@ericmjl
Copy link
Contributor Author

ericmjl commented Jul 11, 2015

Ahhhhh, I should totally run pep8 checking locally before I commit haha. 

Jens, have you ever setup git hooks before? I would like some help, so that I can auto check pep8 prior to committing. 

@jenshnielsen
Copy link
Member

I don't have any experience but it should be possible.

I would recommend installing pep8 and run

python tests.py --pep8

from the main matplotlib dir before committing to git

@jenshnielsen jenshnielsen added the MEP: MEP12 gallery and examples improvements label Jul 12, 2015
@tacaswell tacaswell modified the milestone: proposed next point release Jul 17, 2015
jenshnielsen added a commit that referenced this pull request Jul 20, 2015
@jenshnielsen jenshnielsen merged commit 1812c99 into matplotlib:master Jul 20, 2015
@ericmjl ericmjl deleted the mep12-tex_unicode_demo.py branch July 20, 2015 18:56
@QuLogic QuLogic modified the milestones: v1.5.0, proposed next point release (2.1) Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MEP: MEP12 gallery and examples improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants