Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEP12 on tex_unicode_demo.py #4646

Merged
merged 2 commits into from Jul 20, 2015
Merged

MEP12 on tex_unicode_demo.py #4646

merged 2 commits into from Jul 20, 2015

Conversation

ericmjl
Copy link
Contributor

@ericmjl ericmjl commented Jul 11, 2015

No description provided.

@jenshnielsen
Copy link
Member

PEP8 too

/home/travis/build/matplotlib/matplotlib/examples/pylab_examples/text_handles.py:11:1: E302 expected 2 blank lines, found 1
/home/travis/build/matplotlib/matplotlib/examples/pylab_examples/text_handles.py:33:1: W391 blank line at end of file

@ericmjl
Copy link
Contributor Author

ericmjl commented Jul 11, 2015

Ahhhhh, I should totally run pep8 checking locally before I commit haha. 

Jens, have you ever setup git hooks before? I would like some help, so that I can auto check pep8 prior to committing. 

@jenshnielsen
Copy link
Member

I don't have any experience but it should be possible.

I would recommend installing pep8 and run

python tests.py --pep8

from the main matplotlib dir before committing to git

@jenshnielsen jenshnielsen added the MEP: MEP12 gallery and examples improvements label Jul 12, 2015
@tacaswell tacaswell modified the milestone: proposed next point release Jul 17, 2015
@jenshnielsen jenshnielsen mentioned this pull request Jul 19, 2015
Merged
jenshnielsen added a commit that referenced this pull request Jul 20, 2015
@jenshnielsen
Merge pull request #4646 from ericmjl/mep12-tex_unicode_demo.py
1812c99 
MEP12 on tex_unicode_demo.py
@jenshnielsen jenshnielsen merged commit 1812c99 into matplotlib:master Jul 20, 2015
@ericmjl ericmjl deleted the mep12-tex_unicode_demo.py branch July 20, 2015 18:56
@QuLogic QuLogic modified the milestones: v1.5.0, proposed next point release (2.1) Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MEP: MEP12 gallery and examples improvements
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericmjl @jenshnielsen @tacaswell @QuLogic