FIX: gracefully deal with empty size lists #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HandlerRegularPolyCollection gracefully deal with empty size lists. Fixes matplotlib#4365
|
Interestingly this fails on the scatter_with_legend.py example in the docs build. So whatever that example does should be converted into a test ;) |
|
fixed and moved that example into the tests as a smoke test. Apparently we don't have image test coverage of a scatter plot with a legend?! |
|
no, it looks like there is something subtle going on as the rest of the tests use lists, not arrays |
|
no, we don't test non-scalar sizes anywhere else. |
|
The fix here looks good to me, I just don't know if you are planning to do anything more in this PR. |
|
I am done for now. I think |
WeatherGod
added a commit
that referenced
this pull request
Jul 16, 2015
FIX: gracefully deal with empty size lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HandlerRegularPolyCollection gracefully deal with empty
size lists.
Fixes #4365