remove empty constuctor #4797
Merged
remove empty constuctor #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
attn @pwuertz |
|
I guess it's my personal preference to explicitly implement subclass constructors just in case, but no objections if you prefer to have it removed. |
|
Looking at the other non-gui backends, none of them have their own constructor. I guess I go for extra stuff to maintain. Here for example it only accepts and passes _args and not *_kwargs to the parent class (something I need for MEP27). As this constructor doesn't actually do anything I thought it easier to just remove the whole thing, than add **kwargs, but I don't really mind, but we should stay consistent with the other backends |
|
Right, its easier to maintain in case you want to add something to the base class. No objections. |
tacaswell
added a commit
that referenced
this pull request
Jul 27, 2015
MNT: remove empty constuctor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.