[mpl_toolkits] Allow "figure" kwarg for host functions in parasite_axes

[smheidrich]

Currently, host_axes and host_subplot of mpl_toolkits.axes_grid1 work on pyplot only. This patch allows a kwarg figure (defaulting to pyplot.gcf()) to be passed so it becomes possible to use them on arbitrary figures as well.

[WeatherGod]

don't do equality comparison to None. Always do is and is not.

[WeatherGod]

Also needs documentation (although, I am not clear where...). Besides the equality comment, this makes sense to me. Don't know why it wasn't coded that way before...

[smheidrich]

@WeatherGod thanks for your correction. Both of these functions weren't documented (except for their usage in examples) to begin with, so I'm not sure either. The whole AxesGrid toolkit seems a bit neglected to me, do people still use it?

[WeatherGod]

Oh, absolutely it gets used. It is one of the more popular toolkits.

On Tue, Aug 4, 2015 at 5:23 PM, productivememberofsociety666 <
notifications@github.com> wrote:

@WeatherGod https://github.com/WeatherGod thanks for your correction.
Both of these functions weren't documented (except for their usage in
examples) to begin with, so I'm not sure either. The whole AxesGrid toolkit
seems a bit neglected to me, do people still use it?

—
Reply to this email directly or view it on GitHub
#4863 (comment)
.

[dopplershift]

Someone else just contributed some docs: #4864

[WeatherGod]

In fact, you might be interested in #4864 (just submitted) where someone gives some love to the documentation.

[tacaswell]

I would do this as

fig = kwargs.get('figure', None)
if fig is None:
    fig = plt.gcf()

[tacaswell]

Sorry this languished, in the future leave a comment after you finish with edits. We don't get notifications on commit pushes, just comments.

[tacaswell]

This isn't perfect, but does not make it worse.

[FilipDominec]

Could you, please, point me to a minimum example of using host_axes once

self.fig = matplotlib.figure.Figure(figsize=(8,8))

is defined?

[smheidrich]

@FilipDominec

hax = host_axes([0.1,0.1,0.8,0.8], figure=fig)
hax.plot([0,1,2,3],[1,2,4,8])
fig.savefig("some_file.png")

Result looks very broken though, even when I set figure=plt.gcf() (which is weird because nothing else happens inside the function when figure is None).

I'm using host_subplot with figure kwarg in my own projects. I think I just added the kwarg for host_axes while I was at it because it was almost identical to host_subplot.

[FilipDominec]

@smheidrich Thanks!