Super short lines with arrows do not act well #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th an arrow and a line.
|
This makes sense to me. Waiting for Travis to complete. |
| @@ -3308,7 +3308,9 @@ def transmute(self, path, mutation_size, linewidth): | |||
| x0, y0 = path.vertices[0] | |||
| x1, y1 = path.vertices[1] | |||
|
|
|||
| if self.beginarrow: | |||
| # If there is no room for an arrow and a line, then skip the arrow | |||
| hasBeginArrow = self.beginArrow and not ((x0==x1) and (y0==y1)) | |||
There was a problem hiding this comment.
spelling error, should be lower case beginarrow
Can you use has_begin_arrow for the local variable instead of camel case please?
Probably the same thing with endarrow
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at #3930, but that seems to fix a different problem. The issue here is when there is no room for the arrow head, the '_get_arrow_wedge' method will throw several 'RuntimeWarnings' when it attempts to calculate the arrow head with garbage floats. Since there is no physical space for an arrow head to appear, it makes sense to just skip it. Visually there is no difference.
This addresses an issue in #4897.