Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: set internal flags first in FigureCanvasBase #5150

Merged
merged 7 commits into from Sep 27, 2015

Commits on Sep 26, 2015

  1. FIX: set internal flags first in FigureCanvasBase

    If interactive mode is on using the model where every time any artist is
    invalidated/marked as stale a `draw_idle` is triggered and the user is
    using a non-Agg based backend, saving a png will result in a draw_idle
    call triggered from inside the __init__ method of `FigureCanvasBase`
    which then fails because the full object has not been set up (this is
    not a problem using the IPython hooks because the stale state is only
    checked once when all user code has completed executing).
    
    closes matplotlib#5094
    tacaswell committed Sep 26, 2015
    Copy the full SHA
    67beb95 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e6be6b0 View commit details
    Browse the repository at this point in the history
  3. FIX/API: set_canvas does not mark figure as stale

    This is not part of the state of the figure that will trigger a
    re-drawing.
    
    If the user resets the canvas, it is their responsibility to schedule
    the redraw.
    tacaswell committed Sep 26, 2015
    Copy the full SHA
    77e815e View commit details
    Browse the repository at this point in the history
  4. PRF: prevent possible over draws

    Set the `_is_saving` flag as early as possible in `print_figure`
    to prevent aggressive auto-drawing during the same process.
    tacaswell committed Sep 26, 2015
    Copy the full SHA
    644b4b2 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    db31e6c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2015

  1. Copy the full SHA
    621b98c View commit details
    Browse the repository at this point in the history
  2. TST: be explicit in test_backend_ps

    Random thrashing to prevent the intermittent failures
    tacaswell committed Sep 27, 2015
    Copy the full SHA
    0d465ac View commit details
    Browse the repository at this point in the history