New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc build fixes #5288
Doc build fixes #5288
Changes from 3 commits
c30b74e
bf008b0
7edc583
bf28ffd
711c5b6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ | |
alignment = {'horizontalalignment': 'center', 'verticalalignment': 'baseline'} | ||
# Show family options | ||
|
||
families = ['serif', 'sans-serif', 'cursive', 'fantasy', 'monospace'] | ||
families = ['serif', 'sans-serif', 'monospace'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any particular reason to drop these. While they may not be the most beautiful fonts Travis does include them correctly here http://matplotlib.org/devdocs/examples/pylab_examples/fonts_demo.html There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah. I removed them just because they give a doc build warning on my machine. But if it works on Travis, might as well reinstate. I'll just revert this change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I spent some time at some point finding fonts for all the categories that are free and installed on Travis. See the .travis file. Before that it was a bit of a mess |
||
|
||
font1 = font0.copy() | ||
font1.set_size('large') | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1304,7 +1304,7 @@ def pilread(fname): | |
im = pilread(fname) | ||
if im is None: | ||
raise ValueError('Only know how to handle extensions: %s; ' | ||
'with PIL installed matplotlib can handle ' | ||
'with pillow installed matplotlib can handle ' | ||
'more images' % list(six.iterkeys(handlers))) | ||
return im | ||
|
||
|
@@ -1427,8 +1427,8 @@ def thumbnail(infile, thumbfile, scale=0.1, interpolation='bilinear', | |
make a thumbnail of image in *infile* with output filename | ||
*thumbfile*. | ||
|
||
*infile* the image file -- must be PNG or PIL readable if you | ||
have `PIL <http://www.pythonware.com/products/pil/>`_ installed | ||
*infile* the image file -- must be PNG or pillow-readable if you | ||
have `pillow <http://python-pillow.github.io/>`_ installed | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not a fan of using https in external links where not strictly necessary. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the extra GET and redirect not reason enough? |
||
|
||
*thumbfile* | ||
the thumbnail filename | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pillow may be capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure -- I can capitalize. It's not clear: they have inconsistent capitalization on their website: https://python-pillow.github.io/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring it to being the start of a sentence, not their "brand".