Fix the minortick-fix #5313
Merged
Fix the minortick-fix #5313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry I messed up it last time.
|
The line is now too long for PEP8. Probably best to just wrap after the comma. |
|
Why didn't tests catch this? Seem like a test should have been added. |
|
We have a symlog test, but it doesn't turn on the minor ticks. It would be great to add a test now, or modify the existing symlog test to turn on minor ticks. Also, we seem to have a PEP8 violation now (line too long). |
Merged
|
Should this be backported to 1.5.x? |
|
Nevermind this was backported in #5333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry I messed up it last time and used the wrong name for the symlog-locator.