Fix axes.set_prop_cycle to handle any generic iterable sequence. #5452
Conversation
| @cleanup | ||
| def test_invalid_input_forms(): | ||
| fig, ax = plt.subplots() | ||
| with assert_raises((TypeError, ValueError)): |
There was a problem hiding this comment.
can't use assert_raises as a context manager if you want this to go into the 1.5.x branch. Nose doesn't provide that context manager for python 2.6 for some reason.
There was a problem hiding this comment.
note, since this PR is set up to merge into master, it is ok to keep it this way. Just that the person who backports this has to convert it to the non context manager form.
There was a problem hiding this comment.
According to the what's new page, matplotlib 1.5 dropped support for python 2.6.
There was a problem hiding this comment.
Right, sorry. That was a last minute change that went into 1.5 prior to
release. Carry on.
On Mon, Nov 9, 2015 at 4:44 PM, u55 notifications@github.com wrote:
In lib/matplotlib/tests/test_cycles.py
#5452 (comment):
- ax.set_prop_cycle('linewidth', iter([1, 2]))
- ax.set_prop_cycle('linewidth', np.array([1, 2]))
- ax.set_prop_cycle('color', np.array([[1, 0, 0],
[0, 1, 0],[0, 0, 1]]))- ax.set_prop_cycle(lw=[1, 2], color=['k', 'w'], ls=['-', '--'])
- ax.set_prop_cycle(lw=np.array([1, 2]),
color=np.array(['k', 'w']),ls=np.array(['-', '--']))- assert True
+@cleanup
+def test_invalid_input_forms():
- fig, ax = plt.subplots()
- with assert_raises((TypeError, ValueError)):
According to the what's new page
https://github.com/matplotlib/matplotlib/blob/838502e7ccf5e97e30e3f80db15e00eb124fe600/doc/users/whats_new.rst,
matplotlib 1.5 dropped support for python 2.6.—
Reply to this email directly or view it on GitHub
https://github.com/matplotlib/matplotlib/pull/5452/files#r44336801.
There was a problem hiding this comment.
I knew this was going to be confusing when we decided this awhile ago...
It is that official support for 2.6 ended for v1.5, but it seems that we still have Travis testing v1.5.x branch with python2.6. So, whoever backports this PR should be aware of that.
There was a problem hiding this comment.
@WeatherGod
I only see Travis running tests for versions: 2.7, 3.4, 3.5, and the nightly build 3.6.0a0. Am I missing something?
There was a problem hiding this comment.
https://github.com/matplotlib/matplotlib/blob/v1.5.x/.travis.yml
That is the way it is configured on the 1.5.x branch. Your PR is against master, which is configured differently. But don't worry about it. I will take care of it when I backport this PR.
There was a problem hiding this comment.
Ahh, I see. Thank you for the explanation.
|
I understand why the pep8 Travis test failed, but I don't understand why the first Travis test, 9180.1, failed. Does anyone have an explanation? |
|
We get spurious IO errors in Travis. They typically go away when retrying the test. Since you are going to push up a change to fix the PEP8 problems, we'll see if that test error goes away on its own. |
|
Do I need to rebase and/or create a separate pull request? |
|
neither. Just update your branch with new commits and push that up to github. The PR tracks the branch, not the commit. |
Fix axes.set_prop_cycle to handle any generic iterable sequence.
Fix axes.set_prop_cycle to handle any generic iterable sequence.
|
Backporting PR is #5459 |
Closes issue #5368.