Change streamplot default zorder to 2. #5567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Way back before streamplot gained the zorder kwarg, it used the LineCollection's default zorder, which was 2, but when the kwarg was added, it defaulted to 1. So switch streamplot zorder from 1 back to 2 for consistency.
|
attn @mdboom not sure if this came up in your zero tolerance crusade. |
tacaswell
added a commit
that referenced
this pull request
Nov 30, 2015
FIX/API: Change streamplot default zorder to 2.
|
I didn't come across this in the zero tolerance testing. Is it possible to write a test for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back before
streamplotgained thezorderkwarg, it used theLineCollection's defaultzorder, which was 2, but when the kwarg was added, it defaulted to 1. So switchstreamplotzorderfrom 1 back to 2 for consistency.Fixes #5369.