Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5543: Handle timezone in num2date #5579

Merged
merged 1 commit into from Dec 14, 2015
Merged

Conversation

brendene
Copy link

Please review this fix for #5543

@mdboom mdboom added this to the Critical bugfix release (1.5.1) milestone Nov 28, 2015
@mdboom
Copy link
Member

mdboom commented Nov 28, 2015

@pganssle: Can you confirm this makes sense and doesn't negatively affect the changes you made in this area last year?

Seems fine to me.

@pganssle
Copy link
Member

Sorry, just remembered that I can respond to these notifications by email. I'm out of the country until Wednesday, I'll look at it then.

On November 28, 2015 10:10:10 PM GMT+09:00, Michael Droettboom notifications@github.com wrote:

@pganssle: Can you confirm this makes sense and doesn't negatively
affect the changes you made in this area last year?

Seems fine to me.


Reply to this email directly or view it on GitHub:
#5579 (comment)

@pganssle
Copy link
Member

👍 This was a complete oversight on my part. When I refactored that particular function I forgot to add in the timezone.

Took me forever to review it because every time I tried to look at it in context I kept thinking it was a change to to_ordinalf like an idiot. That was very puzzling.

tacaswell added a commit that referenced this pull request Dec 14, 2015
Fix #5543: Handle timezone in num2date
@tacaswell tacaswell merged commit 0cf4085 into matplotlib:v1.5.x Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants