BUG: Allowing unknown drawstyles #6145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check that forbids `drawstyle` keywords that are not listed in the documentation. Added tests to mimic linestyle tests. Added self to mailmap.
|
@tacaswell Looks like its working now. |
tacaswell
added a commit
that referenced
this pull request
Mar 13, 2016
MNT: fail earlier on unknown draw_style
tacaswell
added a commit
that referenced
this pull request
Mar 13, 2016
MNT: fail earlier on unknown draw_style Conflicts: .mailmap
|
Backported to v2.x as e738593 |
|
@madphysicist Thanks! |
tacaswell
modified the milestones:
2.0 (style change major release),
2.1 (next point release)
|
No problem. Is there a release notes or something like that I should update? |
|
We maintain a Looking into this a bit more, this might have caused a minor regression which is it used to be possible to set the drawstyle to |
|
Fixed that here: #6156. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6143. Added test as well.