Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix and general touch ups for hist3d_demo example (#1702) #6260

Merged
merged 2 commits into from Apr 2, 2016

Conversation

TrishGillett
Copy link
Contributor

@TrishGillett
Copy link
Contributor Author

I can see that the build has failed, but I've looked at the logs and I'm not sure how the failures are actually related to my changes. I'd appreciate some help understanding this. Thanks in advance!

@jenshnielsen
Copy link
Member

The failure on Travis is intermittent and not related to your changes. I have restarted the particular test. I suspect the same is the case on appveyor

@jenshnielsen
Copy link
Member

Appveyor is failing due to #5950 since conda have switched to Numpy 1.11

@TrishGillett
Copy link
Contributor Author

Okay, great, thanks! I see Travis passed this time. :)

@tacaswell tacaswell merged commit 715435c into matplotlib:master Apr 2, 2016
@tacaswell
Copy link
Member

Thanks!

I believe this is your first mpl contribution, congrats and hopefully we will see you again 😄

@TrishGillett
Copy link
Contributor Author

Thanks! I've been looking for something approachable to contribute to, and now that I've discovered MEP12 I'm thinking of sticking around here and working on cleaning up some of the other examples. 😊

@tacaswell
Copy link
Member

Great! Good documentation is very important and an area where mpl could definitely be doing much better. Any work on the examples is very appreciated.

tacaswell added a commit that referenced this pull request Apr 2, 2016
Bug fix and general touch ups for hist3d_demo example

closes #1702
@tacaswell
Copy link
Member

backported to v1.5.x as a8851dd

@QuLogic QuLogic added this to the 1.5.2 (Critical bug fix release) milestone Apr 2, 2016
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request May 22, 2016
Bug fix and general touch ups for hist3d_demo example

closes matplotlib#1702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants