Only render markers on a line when markersize > 0 #6314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 from me! Thanks for the pull request. |
|
👍 from me too Is it possible to add a test to prevent regressions? |
|
So a test for whether indeed nothing is rendered? A problem here is that the #6294 bug occurs with the Adobe Acrobat renderer. During testing, the pdf for comparison is converted to png by Ghostscript. So the faulty behavior would not occur in this setup. Updating the testing to use Acrobat seems like a rather big change and would not work on all systems. |
|
Oh, I didn't realize the effect is only seen with Adobe's renderer. |
|
I'm not 100% sure it's only Acrobat, but I tested with Ghostscript 9.19 and those dots do not show up there. |
tacaswell
added a commit
that referenced
this pull request
Apr 20, 2016
Only render markers on a line when markersize > 0
|
Thanks! Backported to v1.5.x as 38d9638 |
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
May 22, 2016
Only render markers on a line when markersize > 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6294 by only rendering markers when their size is larger than zero.