Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from v2.x #6431

Merged
merged 31 commits into from May 16, 2016
Merged

Merge from v2.x #6431

merged 31 commits into from May 16, 2016

Conversation

efiring
Copy link
Member

@efiring efiring commented May 16, 2016

This merge from v2.x into master also required a little editing, and it involves many changes, hence this PR. I resolved conflicts in .travis.yml and lib/matplotlib/tests/test_colors.py.

tacaswell and others added 29 commits February 24, 2016 23:06
The 'left' and 'right' sliders are both created at 0 and then updated
to the values read out of the figure.  There is logic in the callback
functions to separate singular inputs and a second set of callback
functions to ensure that the min/max stay in the right order.  What was
happening is:

 - both left and right are 0
 - set left to the value from the figure
 - constraint callback fires and sets the minimum of right to be equal
   to the current value of left.  Qt helpfully adjust the value of the
   slider from 0 -> the left value (as 0 is now no longer an allowed
   value)
 - the callback to adjust the figure fires, notes that the left and
   right values are the same and makes the input value a bit smaller
 - propagates that value back to the figure.

The solution is to set the values of each slider before connecting up
the callback.

closes matplotlib#6121
Block pyparsing 2.1.2 which is broken on python3.4
…pect_tick_rcparams

FIX: apply tick.side rcparam to major&minor ticks
…pagation

MNT: key events handler return value to True to stop propagation it gtk
API: Use xkcd: prefix to avoid color name clashes.
…alog

CLN: removing unused DialogLineprops from gtk3
API: ticker.LinearLocator view_limits algorithm changes

closes matplotlib#6142
BUG: copy image data so it can't be modified prior to drawing
The lack of this scale is pointed out in matplotlib#6365 and was the big
difference between pandas AutoDateFormatter and the stock upstream
version.
Closes matplotlib#6270
Also removes an unused argument from the _autolev method.
BUG: fix contour zmin, zmax types to work with LinearLocator
…plit_points

ENH: add musecond scale to AutoDateFormatter
Instead of a hard-coded look for either instance types or strings, make
it a property of the MovieWriter instances. Set the flag to true by
default for the MovieFileWriters (which all seem to work fine) and make
it false by default for MovieWriters (which are currently pipe-based and
break). We can also eliminate looking at strings by doing the check
after we create the instance of MovieWriter (if necessary).
This fixes part of matplotlib#6416 by resetting the 'savefig.bbox' rcParam if it
is set to 'tight'.
@efiring
Copy link
Member Author

efiring commented May 16, 2016

@tacaswell or @jenshnielsen Only appveyor is running on this--no Travis. I imagine this means I broke .travis.yml, but I don't see what the problem is.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone May 16, 2016
# Install only from travis wheelhouse
wheelhouse_pip_install $NUMPY $PANDAS;
# Install only from travis wheelhouse
- if [ -z "$PRE" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipe on the first line is necessary here to get proper multi-line semantics.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you--I completely missed that. I will put it in now.

@efiring
Copy link
Member Author

efiring commented May 16, 2016

@dopplershift, I had to add frame_size_can_vary to NullMovieWriter in test_animation.py. I suspect it could be added to the AbstractMovieWriter instead, but I don't understand all this ABC business, so I'm not sure. I presume there is some reason you didn't add it there.

@tacaswell tacaswell merged commit 927631e into matplotlib:master May 16, 2016
@dopplershift
Copy link
Contributor

@efiring I think AbstractMovieWriter was added post 1.5, so no, I didn't leave it off on purpose--there was no option. 😄 Probably would be better on master to move the property to the abstract base class...

@efiring efiring deleted the merge_from_v2.x branch June 23, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants