Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset text colored by labelcolor param #6445

Merged
merged 2 commits into from May 19, 2016

Conversation

bcongdon
Copy link
Contributor

Addresses #6440.

Sets color of offsetText in set_tick_params to what the labelcolor dictates.

@tacaswell tacaswell added this to the 2.1 (next point release) milestone May 19, 2016
@tacaswell
Copy link
Member

👍 Can you add a test and a whats new entry?

@bcongdon
Copy link
Contributor Author

Yup. Did so.
Not sure why the Travis build is failing, it passed on my fork.

@tacaswell
Copy link
Member

In interest of keeping the repo size and test runtime down this test can probably just be checked by asserting that the offset text has the expected color. Can you make that small change and rebase the png out of existence?

@bcongdon
Copy link
Contributor Author

Yep. Fixed to just check label color.

@tacaswell
Copy link
Member

Thanks!

@tacaswell tacaswell merged commit 9e228e6 into matplotlib:master May 19, 2016
@jenshnielsen
Copy link
Member

Should this be backported to 2.x ?

@tacaswell
Copy link
Member

I am +0.5 on back porting

On Sun, May 22, 2016, 07:59 Jens Hedegaard Nielsen notifications@github.com
wrote:

Should this be backported to 2.x ?


You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
#6445 (comment)

@tacaswell
Copy link
Member

Now I see that this is fixing a bug that was tagged for 2.0, I'll do the backport.

tacaswell added a commit that referenced this pull request May 22, 2016
Offset text colored by labelcolor param
@tacaswell
Copy link
Member

backported to v2.x as 3df2df1

@tacaswell tacaswell modified the milestones: 2.0 (style change major release), 2.1 (next point release) May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants