New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offset text colored by labelcolor param #6445
Conversation
👍 Can you add a test and a whats new entry? |
Yup. Did so. |
In interest of keeping the repo size and test runtime down this test can probably just be checked by asserting that the offset text has the expected color. Can you make that small change and rebase the png out of existence? |
Yep. Fixed to just check label color. |
Thanks! |
Should this be backported to 2.x ? |
I am +0.5 on back porting On Sun, May 22, 2016, 07:59 Jens Hedegaard Nielsen notifications@github.com
|
Now I see that this is fixing a bug that was tagged for 2.0, I'll do the backport. |
Offset text colored by labelcolor param
backported to v2.x as 3df2df1 |
Addresses #6440.
Sets color of
offsetText
inset_tick_params
to what thelabelcolor
dictates.